forked from apache/kvrocks
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] unstable from apache:unstable #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing and testing BITCOUNT with negative start/stop. This patch: 1. Add a `BitmapString::NormalizeRange` for handling the range 2. For BITCOUNT/BITPOS, fixing the syntax of `value.size()` 3. Add the testing
The current encoding design: ``` search data type metadata: key (index name) -> flag | expire | version | size | on_data_type (HASH or JSON) prefixes encoding: key (index name) | PREFIXES -> prefix1 prefix2 ... tag field metadata encoding: key (index name) | TAG_FIELD_META | field name -> separator | case sensitive tag field index encoding: key (index name) | TAG_FIELD | field name | tag | key -> (nil) ```
This PR implemented the cluster slot migration by the rocksdb write batch, which will bring performance benefits. Also, we don't need to depend on parsing commands from the write batch log data if enabled. This makes the cluster migration feature more robust since we don't have to take care of the log data in each write batch. This closes #2008
Co-authored-by: hulk <hulk.website@gmail.com>
…compaction reason (#1962) Co-authored-by: Twice <twice@apache.org>
Co-authored-by: tison <wander4096@gmail.com>
Co-authored-by: mwish <maplewish117@gmail.com> Co-authored-by: hulk <hulk.website@gmail.com> Co-authored-by: 纪华裕 <jihuayu123@gmail.com>
Co-authored-by: hulk <hulk.website@gmail.com>
…#2100) Co-authored-by: hulk <hulk.website@gmail.com>
Co-authored-by: Twice <twice.mliu@gmail.com> Co-authored-by: hulk <hulk.website@gmail.com>
We expired a key with 1 second which is too short for testing the expiration time, because `Metadata::ExpireMsToS` function will use rounding to get a closer time value if METADATA_64BIT_ENCODING_MASK was disabled. This closes #2091
This is a refactor, see: #2076 Previously, adhoc bit operations are used. This patch extract `GetBit` and `SetBitTo` operation to simplify the impl. Also, because the LSB/MSB format we're using it different in BitmapString and Bitmap( see apache/kvrocks-website#198 ), `lsb` and `msb` is extracted to prevent from mistakes.
Just a small corrections of spelling in config file: - rites changes to writes - Removed describing a compression level because we use a hardcode compress_level and no config options for her
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )